Review main Merged

63488[BUGFIX] Only allow scalar values in AssetCollector

Helmut Hummel CR +2 V +2 Easy +29 −18 updated 03/29/22, 07:38

Commit message

Since AssetCollector needs to be serialized,
or to be more precise its state need to be cached as string,
we must avoid that state is stored that isn't serializable.

Therefore we adapt the API to reflect this and change
the API calls to not add non serializable objects.

With this change we also revert the previous USER_INT fix
that bound the AssetCollector unnecessarily to PageRenderer
and store it serialized in cache (the deserialization was
already part of the code of the commit that introduced
the AssetCollector).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6