Review main Merged

63516[BUGFIX] Make tstemplate respect hidden flags for sys_template records

Christian Eßl CR +2 V +2 Easy +12 −4 updated 01/12/22, 10:10

Commit message

Previously, the tstemplate Object Browser would wrongly show hidden
typoscript templates, if they were the first one to be found
(which determined by the sorting key).
The hidden flag will now only be ignored, if a hidden template is
explicitly requested by its uid (using the template selector switch).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2228

Show 23 earlier messages
  1. Christian Eßl uploaded patch set 1 02/29/20, 19:34

  2. TYPO3com voted on patch set 1 V +1 02/29/20, 19:44 Completed build in 10m 09s on Sat, 29 Feb, 07:44 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-878

  3. Susi Moog commented on patch set 1 02/29/20, 20:24

    No vote yet, however, as you only mention the object browser: we should carefully test the impact this has on the frontend - simulation incl. display / usage of hidden records in frontend should still work.
  1. Stefan Froemken commented on patch set 1 V -1 03/03/20, 07:16

    This Patch is the first step into the correct direction. Thank you. If you have a Root Template on your Rootsite and overwrite this TS-Template on a Subpage with a hidden TS-Template, this patch works pretty good. If you now create an additional hidden TS-Template on to the same Subpage, I know that's nasty, a TS-Template Selector appears in TS-Objectbrowser. In that special part your patch does not work.
  2. Christian Eßl commented on patch set 1 03/05/20, 17:04

    > Patch Set 1: Verified-1 > > This Patch is the first step into the correct direction. Thank you. If you have a Root Template on your Rootsite and overwrite this TS-Template on a Subpage with a hidden TS-Template, this patch works pretty good. If you now create an additional hidden TS-Template on to the same Subpage, I know that's nasty, a TS-Template Selector appears in TS-Objectbrowser. In that special part your patch does not work. I have a hard time reproducing that problem. What exactly is the expected state in your case? Just tried that patch on a subpage with two ext templates. No matter their order, I alway get the right values shown in TSOB when switching between the two with the selector.
  3. Christian Eßl commented on patch set 1 03/05/20, 18:09

    > Patch Set 1: > > No vote yet, however, as you only mention the object browser: we should carefully test the impact this has on the frontend - simulation incl. display / usage of hidden records in frontend should still work. This only affects the query done on sys_template. So I can't see a reason how this could affect things like the preview of hidden pages/tt_content records. Or do you mean the TypoScript Waterfall in the adminpanel?
  4. Susi Moog commented on patch set 1 03/06/20, 10:16

    > Patch Set 1: > > > Patch Set 1: > > > > No vote yet, however, as you only mention the object browser: we should carefully test the impact this has on the frontend - simulation incl. display / usage of hidden records in frontend should still work. > > This only affects the query done on sys_template. So I can't see a reason how this could affect things like the preview of hidden pages/tt_content records. > Or do you mean the TypoScript Waterfall in the adminpanel? I meant if the current case is that a hidden template is taken into account when rendering the frontend with hidden records enabled we are changing behaviour here also in frontend. Imagine you have a hidden template with which you are testing new typoscript settings/rendering in preview mode - that would not work anymore if I understand this correctly.
  5. Stefan Froemken commented on patch set 1 03/09/20, 06:58

    "I alway get the right values" Oh, majority, so your Setup is wrong. If both TS-Templates on the Subpage are hidden, there should be visible the value of main TS-Template only. Regardless which hidden TS-Template you have chosen.
  6. Stefan Froemken commented on patch set 1 03/09/20, 08:12

    The Problem is the switch to the Visibility-Aspect. The property showHiddenRecords of TypoScriptFrontendController was by default false. This is correct, as I don't want to see the result of hidden TS-Templates in f.e. ObjectBrowser. With the implementation of VisibilityAspect the new default value is true. That's correct for nearly everything in BE, but not for TS related stuff. IMO it was wrong to remove the showHiddenRecords property. It should be re-implemented.
  7. Stefan Froemken uploaded patch set 2 03/09/20, 08:20

  8. Stefan Froemken voted on patch set 2 V +1 CR +1 03/09/20, 08:21

  9. TYPO3com voted on patch set 2 V -1 03/09/20, 08:30 Completed build in 10m 22s on Mon, 9 Mar, 08:30 AM Test Summary: 1 of 72583 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1161

  10. TYPO3com voted on patch set 2 V +1 03/09/20, 08:43 Completed build in 33m 21s on Mon, 9 Mar, 08:43 AM Test Summary: 72099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1161

  11. Georg Ringer commented on patch set 2 V -1 03/09/20, 10:27

    IMO this the implementation is wrong. Lets give an example. Create a TS record which is hidden with the value ---- lib.hidden = TEXT lib.hidden.value = foo ---- Currently, this value is shown in TSOB and above the select box with constants/setup there is thee record title + the icon with a hidden overlay After applying the patch, the value is NOT shown in TSOB but the TS record is still shown above. I suggest a different approach: Show a infobox with mode danger above the select field with an information like "A hidden TS record is taken into account in this view. It is not used in the Frontend". Something like that
  12. Christian Eßl marked it work in progress 03/09/20, 11:56

  13. Benni Mack wrote 11/29/21, 10:01

    Change destination moved from master to main
  14. Benni Mack updated the commit message in patch set 3 11/29/21, 13:16

  15. Benni Mack uploaded patch set 4 01/10/22, 20:49

  16. Benni Mack marked it ready for review 01/10/22, 20:50

  17. Benni Mack voted on patch set 4 V +1 CR +1 01/10/22, 20:52

  18. core-ci voted on patch set 4 V -1 01/10/22, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21877

  19. core-ci voted on patch set 4 V +1 01/10/22, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21877

  20. Oli Bartsch commented on patch set 4 01/11/22, 10:23

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:150

    According to ext_getFirstTemplate() PHPDoc, @return is array|null. Actually it can also be FALSE. However, just to be more in line with the current definition, should we just use !is_array($this->templateRow) here (like done at other places, e.g. a couple of lines below) or update the PHPDoc?
  21. Oli Bartsch uploaded patch set 5 01/12/22, 00:33

  22. Oli Bartsch commented on patch set 5 V +1 CR +1 01/12/22, 00:33

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:150 Reply

    Done
  23. core-ci voted on patch set 5 V +1 01/12/22, 00:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21947

  24. Benni Mack voted on patch set 5 V +2 CR +2 01/12/22, 10:10

  25. Benni Mack merged patch set 6 01/12/22, 10:10