Review main Merged

63518[BUGFIX] Fix handling of type "comment" in TypoScript Constant Editor

Christian Eßl CR +2 V +2 Easy +5 −5 updated 03/06/20, 18:32

Commit message

According to the documentation, the boolean checkbox for type "comment"
should behave in the following way:
- checked= “”
- not-checked = “#”

The handling of this behaviour was faulty in the TypoScript Constant
Editor. This means, every time the constants were saved without changing
the "comment" checkbox, its value was reversed.
Further information:
https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/UsingSetting/TheConstantEditor.html

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1