63542[TASK] Transform PageBrowsingViewHelper to TagBasedViewHelper
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Eßl +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Eßl +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Georg Ringer uploaded patch set 1 03/04/20, 04:44
-
Georg Ringer commented on patch set 1 03/04/20, 04:45
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 03/04/20, 04:54 Completed build in 10m 09s on Wed, 4 Mar, 04:54 AM Test Summary: 71806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-958
-
Christian Eßl voted on patch set 1 V +1 CR +1 03/04/20, 06:33
-
Oli Bartsch voted on patch set 1 CR +1 03/04/20, 06:42
-
Stefan Froemken commented on patch set 1 CR +1 03/04/20, 07:27
I know it's just an update of the ViewHelper, but I miss descriptions. There is no description for the ViewHelper Arguments and no usage description for the ViewHelper itself. -
Georg Ringer rebased onto patch set 2 03/04/20, 07:42
-
Georg Ringer commented on patch set 2 03/04/20, 07:43
@Stefan: feel free to create a new issue for that, I don't want to mix that with this patch -
Benni Mack updated the commit message in patch set 3 03/04/20, 07:56
-
Christian Eßl voted on patch set 3 V +1 CR +1 03/04/20, 07:58
-
TYPO3com voted on patch set 2 V +1 03/04/20, 08:07 Completed build in 21m 44s on Wed, 4 Mar, 08:07 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-963
-
TYPO3com voted on patch set 3 V +1 03/04/20, 08:27 Completed build in 30m 40s on Wed, 4 Mar, 08:27 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-966
-
Oli Bartsch voted on patch set 3 CR +1 03/04/20, 08:34
-
Benni Mack voted on patch set 3 V +2 CR +2 03/06/20, 07:47
-
Benni Mack commented on patch set 3 03/06/20, 07:47
Nice one, this helps a lot in projects with EXT:indexed_search -
Benni Mack merged patch set 4 03/06/20, 07:47