Review main Merged

63567[BUGFIX] Ask user for notifications before requesting permissions

Frank Nägler CR +2 V +2 Easy +44 −3 updated 03/20/20, 06:25

Commit message

Since Firefox 72 a user interaction is required to prompt the user for native
browser notification permissions. This should prevent the user for
notification SPAM.

This patch introduces a modal confirmation, to get this user interaction.
The user is asked only once (as before), this is possible because the
modal is triggered only if a UC setting is not present.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3