Review 9.5 Merged

63572[BUGFIX] Do not assign tab items if their content is empty

Daniel Goerz CR +2 V +2 Easy +16 −12 updated 03/06/20, 15:33

Commit message

In a TabsContainer, if all the fields of a tab are hidden to the editor
(by disabling them in PageTS), the tab would still become assigned in
the 'items' fluid variable. The empty, but invisible, tab would then
still be considered for determining the active tab in the view. If the
first tab was disabled in this way, the editor would see no active tab
at all.
To prevent this from happening, the tab elements are now never assigned,
if their content is completely empty.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2