Review 9.5 Abandoned

63576[BUGFIX] LinkService should identify urls starting with //

Daniel Goerz CR 0 V 0 Easy +8 −2 updated 06/21/20, 12:58

Commit message

Urls starting with `//` should have a proper fallback to
avoid warnings e.g. in InputLinkElement that this type of url
is unknown.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 68

  1. Daniel Goerz commented on patch set 1 03/06/20, 21:59

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/LinkHandling/LinkService.php
  2. TYPO3com voted on patch set 1 V -1 03/06/20, 21:59 Completed build in 18s on Fri, 6 Mar, 09:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-168

  3. Daniel Goerz uploaded patch set 2 03/06/20, 22:13

  4. Daniel Goerz commented on patch set 2 03/06/20, 22:13

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 03/06/20, 22:24 Completed build in 11m 31s on Fri, 6 Mar, 10:24 PM Test Summary: 74449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-169

  6. Daniel Goerz commented on patch set 2 V -1 03/07/20, 09:18

    I have different behavior in 9 than I had in 10 with this patch applied. Georg can you check, please?
  7. Benni Mack commented on patch set 2 06/04/20, 19:31

    ping. either we'll get this into the next v9 release, or let's abandon this issue
  8. Daniel Goerz abandoned the change 06/21/20, 12:58

    As suggested by benni