Review 9.5 Merged

63587[BUGFIX] Use parent page ID as PID for suggest fields

Benni Mack CR +2 V +2 Easy +1 −1 updated 03/08/20, 20:20

Commit message

TCA select fields have the capabilities for replacing ###CURRENT_PID###
with the parent page ID of the current record. This should always be
<table>.pid. In case of pages the wrong ID was used.

This was now changed to always use the parent page ID indepentent of
the current record. In case there is no parent page row, 0 is given.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 03/08/20, 19:59

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/08/20, 20:12 Completed build in 12m 13s on Sun, 8 Mar, 08:12 PM Test Summary: 74457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-191

  3. Benni Mack voted on patch set 1 V +2 CR +2 03/08/20, 20:20

  4. Benni Mack merged patch set 2 03/08/20, 20:20