Review main Merged

63594[BUGFIX] Add formDataProvider DatabasePageRootline to flexFormSegment

Georg Ringer CR +2 V +2 Easy +5 −0 updated 03/07/20, 15:16

Commit message

The variable ###SITEROOT### can only be correctly substituted if the
DatabasePageRootline provider is used. There it is added to the
flexFormSegment as well.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • Christian Eßl +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Georg Ringer uploaded patch set 1 03/07/20, 00:03

  2. Georg Ringer commented on patch set 1 03/07/20, 00:03

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/07/20, 00:16 Completed build in 12m 34s on Sat, 7 Mar, 12:16 AM Test Summary: 72091 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1066

  4. Susi Moog updated the commit message in patch set 2 03/07/20, 09:38

  5. TYPO3com voted on patch set 2 V +1 03/07/20, 09:49 Completed build in 10m 59s on Sat, 7 Mar, 09:49 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1073

  6. Benni Mack voted on patch set 2 CR +1 03/07/20, 11:01

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/07/20, 11:26

  8. Christian Eßl voted on patch set 2 V +1 CR +1 03/07/20, 11:53

  9. Susi Moog voted on patch set 2 V +2 CR +2 03/07/20, 15:15

  10. Susi Moog merged patch set 3 03/07/20, 15:16