Review main Merged

6364[BUGFIX] Empty text with non-localizable label key

Xavier Perseguers CR +2 V +2 Easy +18 −0 updated 06/03/13, 20:49

Commit message

When method $GLOBALS['TSFE']->sL() is called with a non-localizable
label key (not starting with "LLL:"), an empty string is returned
instead of the label key itself.

This is a breaking change with previous versions of TYPO3.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Files 2

Review log 6

  1. Andreas Wolf merged patch set 1 10/28/11, 11:35

  2. Andreas Wolf uploaded patch set 2 10/28/11, 11:35

  3. Andreas Wolf commented on patch set 2 V 0 10/28/11, 11:35

    by team member; Looks good to me, approved Added a unit test for this case. As this test clearly shows that the fix is working (and it is rather trivial), I submit this, though it misses one "verified" vote.
  4. Markus Klein commented on patch set 1 10/28/11, 11:35

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 10/28/11, 11:35

  6. Mr. Jenkins commented on patch set 2 10/28/11, 11:35