Review main Merged

63696[BUGFIX] Check "tables_modify" permissions in list module

Christian Eßl CR +2 V +2 Easy +11 −6 updated 03/18/20, 19:22

Commit message

If an editor has "view" permissions set for a table, but no "modify"
permissions, the record list would still show many buttons related to
modifying records, to the user: "Add", "Edit", "Copy", "Cut" actions.
Trying to click one of these buttons would lead the editor to a broken
page that just shows an infinite loading spinner.

This patch now adds "tables_modify" permission checks to many places in
the code. The following adjustments were made:

- Check modify permissions on "copy" in RecordProvider (context menu)
- Check table modify permissions in DatabaseRecordList

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 2