Review main Merged

63728[BUGFIX] Avoid error when using admPanel.hide = 1

Chris Müller CR +2 V +2 Normal +144 −1 updated 03/15/20, 07:30

Commit message

The method StateUtility::isHiddenForUser must return a bool,
but instead the User TSconfig setting admPanel.hide = 1
was returned unchanged as a string. This conflicts with
the defined return type.

Additionally, a check on the backend user is added to
avoid another error when it is null.

Furthermore, missing tests in StateUtility are added.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2