Review 9.5 Merged

63739[BUGFIX] Allow TYPO3_CONTEXT to be set from Apache2 with suexec support

Daniel Goerz CR +2 V +2 Easy +9 −1 updated 03/15/20, 11:35

Commit message

Apache2 suexec support prefixes environment variables with HTTP_ in order
to whitelist environment variables - this is what TYPO3 is using for TYPO3_CONTEXT.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Daniel Goerz commented on patch set 1 03/15/20, 10:25

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
  2. TYPO3com voted on patch set 1 V -1 03/15/20, 10:26 Completed build in 27s on Sun, 15 Mar, 10:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-231

  3. Daniel Goerz commented on patch set 2 03/15/20, 10:28

    Published edit on patch set 1.
  4. Daniel Goerz commented on patch set 3 03/15/20, 10:29

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V +1 03/15/20, 10:40 Completed build in 11m 48s on Sun, 15 Mar, 10:40 AM Test Summary: 74544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-232

  6. TYPO3com voted on patch set 3 V -1 03/15/20, 10:51 Completed build in 14m 19s on Sun, 15 Mar, 10:51 AM Test Summary: 74031 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-234

  7. TYPO3com voted on patch set 3 V +1 03/15/20, 11:21 Completed build in 57m 46s on Sun, 15 Mar, 11:20 AM Test Summary: 74544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-234

  8. Daniel Goerz commented on patch set 3 03/15/20, 11:23

    This change is ready for review.
  9. Susi Moog voted on patch set 3 V +1 CR +1 03/15/20, 11:33

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 03/15/20, 11:35

  11. Daniel Goerz merged patch set 4 03/15/20, 11:35