Review 9.5 Merged

63745[BUGFIX] Make SQL schema migrations working on SQLite

Benni Mack CR +2 V +2 Hard +48 −878 updated 03/17/20, 08:14

Commit message

This patch fixes three things:

1) SQLite can handle a primary key, the special handling
   can be removed. The field names must be quoted though.
   A lot of duplicate tests can be removed here.

2) The handcrafted arrays passed on to the TableDiff class
   need to be indexed by the column or index name, otherwise
   the SQLite driver fails to identify them correctly.

3) Allow only one column operation per table.
   Having multiple column adjustments (rename, removal)
   within one run generates wrong migration SQL.
   This is due to the possibility of the Install Tool
   to be able to select on a "per column" level.
   (Keep in mind that in SQLite one operation needs at
   least 5 SQL statements, contrary to other DMBS)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 4