Review main Merged

63756[BUGFIX] Show latest rss entries first in rss widget

Daniel Siepmann CR +2 V +2 Easy +8 −9 updated 04/14/20, 20:28

Commit message

Sort rss entries before reducing to shown limit.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1

Issues 1

Files 1

Review log 1925

  1. Daniel Siepmann uploaded patch set 1 03/17/20, 12:42

  2. Daniel Siepmann updated the commit message in patch set 2 03/17/20, 12:42

  3. Daniel Siepmann uploaded patch set 3 03/17/20, 12:44

  4. Georg Ringer voted on patch set 3 CR +1 03/17/20, 12:51

  5. TYPO3com voted on patch set 1 V -1 03/17/20, 12:54 Completed build in 11m 34s on Tue, 17 Mar, 12:54 PM Test Summary: 61827 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1396

  6. TYPO3com voted on patch set 2 V +1 03/17/20, 12:59 Completed build in 16m 30s on Tue, 17 Mar, 12:59 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1397

  7. TYPO3com voted on patch set 3 V +1 03/17/20, 13:03 Completed build in 13m 04s on Tue, 17 Mar, 01:03 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1398

  8. Oli Bartsch commented on patch set 3 V -1 03/17/20, 13:11

    The cache is now never be set. Side note: What if a rss feed doesn't provide `pubDate`?
  9. Daniel Siepmann uploaded patch set 4 03/17/20, 13:20

  10. Daniel Siepmann commented on patch set 4 03/17/20, 13:22

    > Patch Set 3: Verified-1 > > The cache is now never be set. > > Side note: What if a rss feed doesn't provide `pubDate`? Yeah sorry, caching is restored ;) Regarding pubDate: I didn't change the "requirement". It was also required beforehand, at least it was casted to string. I would need to check how that situation is handled by PHP. But I guess we just expect it to exist anyway right now?

    AbstractRssWidget.php:90 Unresolved

    I'm aware this might consume a lot of ram. I'm not sure how to circumvent that situation. All feedback is welcome.
  11. Oli Bartsch commented on patch set 4 03/17/20, 13:30

    > Patch Set 4: > > (1 comment) > > > Patch Set 3: Verified-1 > > > > The cache is now never be set. > > > > Side note: What if a rss feed doesn't provide `pubDate`? > > Yeah sorry, caching is restored ;) > > Regarding pubDate: I didn't change the "requirement". It was also required beforehand, at least it was casted to string. I would need to check how that situation is handled by PHP. But I guess we just expect it to exist anyway right now? Yep fine for me for now. As said, that was just a thing I noticed will looking into the code. I think it was not noticed before as it was "just one array item".
  12. TYPO3com voted on patch set 4 V +1 03/17/20, 13:32 Completed build in 11m 34s on Tue, 17 Mar, 01:32 PM Test Summary: 72036 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1399

  13. Richard Haeser commented on patch set 4 04/03/20, 16:10

  14. Guido Schmechel voted on patch set 4 CR +1 04/04/20, 13:37

  15. Alexander Schnitzler commented on patch set 4 04/04/20, 15:08

    Unresolved

    We should call this latest rss entries as this is about the age of entries and not their condition.
  16. Josef Glatz updated the commit message in patch set 5 04/14/20, 08:45

  17. TYPO3com voted on patch set 5 V -1 04/14/20, 08:45 Completed build in 21s on Tue, 14 Apr, 08:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2478

  18. Richard Haeser commented on patch set 5 CR -1 04/14/20, 08:47

    Will have a look at this patch tonight. We need to change this patch to the just changed way of registering widgets.
  19. Josef Glatz commented on patch set 5 04/14/20, 08:48

    > Patch Set 5: Code-Review-1 > > Will have a look at this patch tonight. We need to change this patch to the just changed way of registering widgets. 👍
  20. Richard Haeser uploaded patch set 6 04/14/20, 20:16

  21. Richard Haeser voted on patch set 6 V +1 CR +1 04/14/20, 20:17

  22. Georg Ringer voted on patch set 6 V +2 CR +2 04/14/20, 20:20

  23. Georg Ringer merged patch set 7 04/14/20, 20:20

  24. Jonas Eberle commented on patch set 7 04/14/20, 20:23

    RssWidget.php:121 Unresolved

    I suggest to catch the Exception if a malformed string comes in
  25. TYPO3com voted on patch set 6 V +1 04/14/20, 20:28 Completed build in 11m 23s on Tue, 14 Apr, 08:28 PM Test Summary: 73520 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2533