6379[BUGFIX] Multiple values not displayed for simple items lists
Commit message
Review
-
Code review CR +2
- Francois Suter +2
- Björn Pedersen +1
- Markus Klein +1
-
Verified V +2
- Francois Suter +2
- Markus Klein +1
Issues 1
Files 1
Review log 23
-
Francois Suter uploaded patch set 2 12/16/11, 13:12
-
Francois Suter commented on patch set 2 12/16/11, 13:12
New patch takes into account the whitespace/tab changes from merged version for TYPO3 4.5. -
Francois Suter uploaded patch set 3 12/16/11, 13:12
-
Francois Suter commented on patch set 3 12/16/11, 13:12
Patch set 3 addresses the comments. Please cast your vote again. -
Xavier Perseguers commented on patch set 1 12/16/11, 13:12
Please see review in TYPO3_4-5 branch (I did not see it was for 4.5). And do not push patches to all branches until it is fully reviewed, this eases the review process. -
Xavier Perseguers commented on patch set 2 2 comments 12/16/11, 13:12
Verified; I would prefer that you didn't submit this Thanks for this patch and the way you advertised it (screenshot). Please see inline comments to understand -1 on code review. -
Michael Stucki commented on patch set 4 12/16/11, 13:12
Looks good to me, but someone else must approve Code review is fine but I haven't tested it yet. -
Michael Stucki uploaded patch set 5 12/16/11, 13:12
-
Michael Stucki commented on patch set 5 12/16/11, 13:12
Uploaded a new version which is rebased on the current master branch (otherwise I've been getting conflicts because of the linkvalidator submodule change). Someone please verify if I did this properly, thanks in advance... -
Francois Suter commented on patch set 5 V 0 12/16/11, 13:12
by team member; Looks good to me, approved Well-test and reviewed across all branches. -
Björn Pedersen commented on patch set 5 12/16/11, 13:12
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 5 12/16/11, 13:12
Verified; Looks good to me, but someone else must approve -
Xavier Perseguers uploaded patch set 4 12/16/11, 13:12
-
Xavier Perseguers commented on patch set 4 12/16/11, 13:12
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 12/16/11, 13:12
This patchset depends on an abondoned patchset. -
Mr. Jenkins commented on patch set 1 12/16/11, 13:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2336/ : SUCCESSclass.t3lib_befunc.php:1796Please use tabsclass.t3lib_befunc.php:1805Please use tabs -
Mr. Jenkins commented on patch set 1 12/16/11, 13:12
No score -
Mr. Jenkins commented on patch set 1 2 comments 12/16/11, 13:12
Looks good to me, but someone else must approve Only some nitpicking. See the inline comments. -
Mr. Jenkins commented on patch set 2 12/16/11, 13:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2464/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/16/11, 13:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2472/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/16/11, 13:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2473/ : SUCCESS -
Mr. Jenkins commented on patch set 5 12/16/11, 13:12
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2601/ : SUCCESS -
Francois Suter merged patch set 5 12/16/11, 13:12