Review main Merged

63798[BUGFIX] Cast string to float in NumberViewHelper

Susi Moog CR +2 V +2 Easy +17 −1 updated 03/19/20, 16:28

Commit message

While number_format does an internal cast to float, it does not cast
things like empty strings to 0 - instead a PHP warning is emitted.

To catch that edge case, we are now casting to float before calling
number_format.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2