63827[FEATURE] Allow specific language parameter in page-link related ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Georg Ringer +1
- Achim Fritz +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Achim Fritz +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Feature-90613-AddLanguageArgumentToPage-relatedLinkViewHelpersAndUriViewHelpersInFluid.rst1new+64 −0
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+26 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php2+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php1+4 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php3+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+4 −0
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/PageViewHelperTest.php+1 −0
Review log 1821
-
Benni Mack uploaded patch set 1 03/21/20, 14:35
-
TYPO3com voted on patch set 1 V +1 03/21/20, 14:47 Completed build in 11m 23s on Sat, 21 Mar, 02:47 PM Test Summary: 72231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1544
-
Georg Ringer commented on patch set 1 CR -1 03/21/20, 19:28
-
Benni Mack commented on patch set 1 03/23/20, 09:11
PageViewHelper.php:85Reply Unresolvedyeah, but the case is that some people want to enforce "current" (in the related issue). In addition, we _could_ in the future use them to use non-numeric values (namely "locales"). -
Georg Ringer voted on patch set 1 CR 0 03/23/20, 09:28
-
Daniel Goerz commented on patch set 1 03/23/20, 13:08
TypolinkViewHelper.php:160UnresolvedThis is always set as we define a default value in the argument. Also, why not handle it the same way, the other instructions are handled above?PageViewHelper.php:102Must be (string)$arguments['language']! Also shouldn't we fall back to 'current' here as well instead of falling back to null to be more consistent? -
Daniel Goerz commented on patch set 1 03/23/20, 13:10
PageViewHelper.php:102ReplyAlso, it should always be set. -
Benni Mack commented on patch set 1 04/15/20, 08:40
PageViewHelper.php:102Reply UnresolvedIt should not fall back to "current" as this would override get parameters (L), which is handled in PageLinkBuilder already. This would then be breaking / different behaviour, if it is not explicit set. -
Benni Mack uploaded patch set 2 04/15/20, 09:03
-
Georg Ringer commented on patch set 2 CR -1 04/15/20, 09:07
Feature-90613-AddLanguageArgumentToPage-relatedLinkViewHelpersAndUriViewHelpersInFluid.rst:45Unresolvedshould we use a different language there, otherwise it is bit strange having it twice -
Benni Mack commented on patch set 3 04/15/20, 09:09
Published edit on patch set 2. -
Daniel Goerz voted on patch set 3 CR +1 04/15/20, 09:13
-
TYPO3com voted on patch set 2 V +1 04/15/20, 09:26 Completed build in 21m 33s on Wed, 15 Apr, 09:26 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2563
-
TYPO3com voted on patch set 3 V +1 04/15/20, 09:30 Completed build in 14m 01s on Wed, 15 Apr, 09:30 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2564
-
Georg Ringer voted on patch set 3 V +1 CR +1 04/15/20, 09:30
-
Achim Fritz voted on patch set 3 V +1 CR +1 04/15/20, 10:52
-
Benni Mack voted on patch set 3 V +2 CR +2 04/15/20, 11:00
-
Benni Mack merged patch set 4 04/15/20, 11:00
-
Markus Klein commented on patch set 4 08/09/23, 16:55
Any specific reason this wasn't also implemented for the other "page related" link viewhelper like "link.action" etc? -
Benni Mack commented on patch set 4 08/09/23, 21:08
Reply
no -
Markus Klein commented on patch set 4 08/28/23, 13:29
Reply
PageViewHelper.php:85