Review main Abandoned

63916[WIP][BUGFIX] Rework cObj->getTreeList()

Benni Mack CR 0 V 0 Normal +246 −3 updated 04/20/20, 20:00

Commit message

The method for fetching the subpages of a page ID built in cObj->getTreeList()
has various drawbacks:
- multi-functional values (negative IDs)
- inflexible enableFields selection

In addition it has a faulty behavior when dealing with workspaces and
when a backend user is previewing hidden content.

In general, this method rather belongs to PageRepository, which can
then be used in other places as well.

ToDo
- What we need is functional tests to show the behavior based on various
settings which could work.
- In this setting, we could/should also incorporate the caching framework
- Also, deprecating getTreeList() would make a lot of sense

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4