Review main Merged

6392[BUGFIX] Add check for salted default admin password

Gregor Hermens CR +2 V +2 Easy +31 −9 updated 06/03/13, 20:49

Commit message

Check for default password of admin account no longer
works in status reports module.

Review

  • Code review CR +2
    • Francois Suter +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Francois Suter +2
    • Philipp Gampe +1

Files 1

Review log 23

  1. Francois Suter uploaded patch set 2 10/31/11, 20:34

  2. Francois Suter uploaded patch set 3 10/31/11, 20:34

  3. Francois Suter commented on patch set 3 10/31/11, 20:34

    Verified; Looks good to me, but someone else must approve Disregard Patch Set 2, Patch Set 3 is an improved version. The main change is to add a "elseif" logic, since both tests are mutually exclusive. Otherwise the differences with Patch Set 1 are mostly CGL cleanups. I also added 4.7 to the releases in the commit message.
  4. Gregor Hermens commented on patch set 3 10/31/11, 20:34

    Verified; Looks good to me, but someone else must approve Thanks for the CGL cleanups, Francois...
  5. Francois Suter commented on patch set 4 10/31/11, 20:34

    Ah I see, but then we could have: if (t3lib_extMgm::isLoaded('saltedpasswords') && (tx_saltedpasswords_div::isUsageEnabled('BE')) { and then the "elseif" for the md5 check, right? And BTW you can't vote for your own patch ;-)
  6. Francois Suter commented on patch set 4 10/31/11, 20:34

    Verified; Looks good to me, but someone else must approve OK, then the current version is fine.
  7. Gregor Hermens uploaded patch set 4 10/31/11, 20:34

  8. Gregor Hermens commented on patch set 4 10/31/11, 20:34

    Verified; Looks good to me, but someone else must approve The elseif logic of patch set 3 ignores cases, where tx_saltedpasswords is loaded, but disabled for the BE, or old passwords have not yet been updated. Patch set 4 reverts this to the logic of patch set 1, but with all the CGL cleanups.
  9. Gregor Hermens commented on patch set 4 10/31/11, 20:34

    No score; No score This would only help, if tx_saltedpasswords is loaded, but disabled. If tx_saltedpasswords is enabled, but the password has not been updated yet, the elseif would prevent the second check, so no warning would be issued.
  10. Francois Suter commented on patch set 5 10/31/11, 20:34

    Verified; Looks good to me, but someone else must approve Ah yes, sorry, it's the commit that changed. Everything seems ok then, I'll take care of the commit later.
  11. Francois Suter commented on patch set 5 10/31/11, 20:34

    Do not submit Hey Markus, I can't see any difference in the actual code patch. The commit message is indeed a bit better, but now you appear as the author which is wrong. Didn't you use cherry-pick to start with?
  12. Francois Suter commented on patch set 5 V 0 10/31/11, 20:34

    by team member; Looks good to me, approved
  13. Markus Klein uploaded patch set 5 10/31/11, 20:34

  14. Markus Klein commented on patch set 5 10/31/11, 20:34

    Looks good to me, but someone else must approve Just cleaned the commit message and removed redundant information.
  15. Markus Klein commented on patch set 5 10/31/11, 20:34

    As far as I can see this, the author is still Gregor, though.
  16. Philipp Gampe commented on patch set 5 V 0 10/31/11, 20:34

    Review is ok too, but I want to wait for your answer to Francois questions.
  17. Philipp Gampe commented on patch set 5 10/31/11, 20:34

    Looks good to me, but someone else must approve Markus is right.
  18. Mr. Jenkins commented on patch set 1 10/31/11, 20:34

  19. Mr. Jenkins commented on patch set 2 10/31/11, 20:34

  20. Mr. Jenkins commented on patch set 3 10/31/11, 20:34

  21. Mr. Jenkins commented on patch set 4 10/31/11, 20:34

  22. Mr. Jenkins commented on patch set 5 10/31/11, 20:34

  23. Francois Suter merged patch set 5 10/31/11, 20:34