Review main Merged

63996[TASK] Change boolean HTML attributes in AssetCollector ViewHelpers

Jonas Eberle CR +2 V +2 Easy +18 −4 updated 03/28/20, 22:04

Commit message

As boolean HTML attributes shall either have a value equal to the
attribute name (e.g. async="async") or have no value at all (only allowed
in HTML5), the ViewHelper reflects that now.

All boolean HTML attributes on <script> (async, defer, nomodule) and
<link> (disabled) have been changed to Fluid "bool" ("0" and "false" is
false, rest is true).

This allows using the ViewHelpers with e.g. async="1" which before would
have output <script async="1">. Now it is registered as async="async"
with AssetCollector.

References:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2