Review 9.5 Merged

64011[TASK] Remove dependency to algo26-matthias/idna-convert

Benni Mack CR +2 V +2 Nightmare +4074 −65 updated 04/15/20, 18:40

Commit message

The third-party library algo26-matthias/idna-convert is not compatible
with PHP 7.4 (used for providing IDNA conversions for umlaut domains).

The classes from v1 are copied in order to have them still available, but we
maintain the code ourselves and reduce the usage to a minimum.

  composer remove "algo26-matthias/idna-convert:"

See https://idnaconv.net/docs.html for detailed upgrade
changes.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 18