Review main Merged

64019[BUGFIX] Use direct calls to BackendLayoutView

Benni Mack CR +2 V +2 Easy +4 −2 updated 04/02/20, 10:23

Commit message

Instead of using "callUserFunction" which hands in an instance
of the current object for BackendLayoutView, which is never needed,
this change uses the method calls directly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 510

  1. Benni Mack uploaded patch set 1 03/30/20, 19:32

  2. TYPO3com voted on patch set 1 V -1 03/30/20, 19:44 Completed build in 12m 00s on Mon, 30 Mar, 07:44 PM Test Summary: 1 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1985

  3. TYPO3com commented on patch set 1 03/31/20, 09:19 Completed build in 13h 58m 57s on Tue, 31 Mar, 09:19 AM Test Summary: 5 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1985

  4. Georg Ringer voted on patch set 1 V +1 CR +1 03/31/20, 09:32

  5. TYPO3com commented on patch set 1 03/31/20, 09:59 Completed build in 4h 26m 11s on Tue, 31 Mar, 09:59 AM Test Summary: 1 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1985

  6. Oliver Klee voted on patch set 1 CR +1 03/31/20, 10:02

  7. TYPO3com commented on patch set 1 03/31/20, 10:07 Completed build in 19h 01m 53s on Tue, 31 Mar, 10:07 AM Test Summary: 4 of 73534 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1985

  8. TYPO3com voted on patch set 1 V +1 03/31/20, 11:15 Completed build in 10h 45m 05s on Tue, 31 Mar, 11:15 AM Test Summary: 73048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1985

  9. Andreas Kienast voted on patch set 1 V +2 CR +2 04/02/20, 10:23

  10. Andreas Kienast merged patch set 2 04/02/20, 10:23