Review main Merged

64073[TASK] Lift doktype restrictions in SlugHelper::resolveParentPageRecord

Christian Eßl CR +2 V +2 Easy +9 −3 updated 04/14/20, 15:08

Commit message

The changes made in #18079 lifted the restrictions for using doktypes
with a number higher than 200 in several parts of the frontend.
These restrictions were still present in the SlugHelper upon resolving
a parent page record (which automatically fetches the slugs of parent
pages for a child page upon creating its slug).
This hard restriction made it impossible to automatically resolve the
slug of a parent page with a doktype higher than 200.

The check is now adjusted to solely exclude the following doktypes:
* DOKTYPE_SPACER (199)
* DOKTYPE_SYSFOLDER (254)
* DOKTYPE_RECYCLER (255)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1