Review main Merged

64094[BUGFIX] Use single type @var in LogEntry model properties

Daniel Siepmann CR +2 V +2 Easy +12 −2 updated 04/07/20, 16:15

Commit message

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018
several @var annotations have been adjusted to reflect the
actual used type of properties.

This however led to the issue that several properties of
Extbase models had one type as annotation but used more
than one specific type internally. Adding the additional
type made phpstan happy but broke the property mapper of
Extbase, which expects just one type to be annotated via
@var.

Therefore, the @var annotations in the affected models
have been reverted to their original state and the
reoccurring errors have been put onto phpstans list of
ignored errors.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2