Review main Merged

64099[BUGFIX] Iterate over record row only if available

Georg Ringer CR +2 V +2 Easy +6 −6 updated 04/08/20, 16:42

Commit message

The row must only be processed if available.

Review

  • Code review CR +2 Done
    • Christian Eßl +2
    • Josef Glatz +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Eßl +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 04/08/20, 11:19

  2. Georg Ringer commented on patch set 1 04/08/20, 11:19

    This change is ready for review.
  3. Tymoteusz Motylewski commented on patch set 1 04/08/20, 11:25

    is it only for master or should also be for v9.5?
  4. Andreas Kienast voted on patch set 1 CR +1 04/08/20, 11:35

  5. TYPO3com voted on patch set 1 V +1 04/08/20, 12:00 Completed build in 20m 39s on Wed, 8 Apr, 12:00 PM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2294

  6. Josef Glatz commented on patch set 1 CR +1 04/08/20, 13:11

    Code change is understandable and looks good > Can't verify for now, since I can't reproduce the exception actually with a really simple page tree with subpages and some dummy content elements in my almost clean master.
  7. Christian Eßl voted on patch set 1 V +2 CR +2 04/08/20, 15:15

  8. Christian Eßl merged patch set 2 04/08/20, 16:42