64108[TASK] Add ability to highlight page of draft record
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- Build/Sources/Sass/component/_svgtree.scss+24 −0
- Build/Sources/TypeScript/workspaces/backend.ts+34 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+7 −0
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+10 −0
- typo3/sysext/workspaces/Classes/EventListener/PageTreeItemsHighlighter.php+8 −0
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+3 −0
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
Review log 2130
Show 35 earlier messages
-
Uwe Trotzek uploaded patch set 1 04/09/20, 10:28
-
TYPO3com voted on patch set 1 V -1 04/09/20, 10:28 Completed build in 24s on Thu, 9 Apr, 10:28 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2342
-
Uwe Trotzek uploaded patch set 2 04/09/20, 10:32
-
TYPO3com voted on patch set 2 V +1 04/09/20, 10:47 Completed build in 14m 23s on Thu, 9 Apr, 10:47 AM Test Summary: 73369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2344
-
Björn Jacob commented on patch set 2 04/11/20, 06:37
Same here as in 64109 ;) > A nitpick. Regarding to the contribution guide please start with a capital letter "Add ability...". And please put the Change-Id as the last element behind "Releases...". Thx :)
-
Anja Leichsenring updated the commit message in patch set 3 04/12/20, 10:45
-
TYPO3com voted on patch set 3 V +1 04/12/20, 11:00 Completed build in 14m 22s on Sun, 12 Apr, 11:00 AM Test Summary: 73397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2393
-
Uwe Trotzek commented on patch set 3 04/14/20, 08:22
> Patch Set 2: > > Same here as in 64109 ;) > > > A nitpick. Regarding to the contribution guide please start with a capital letter "Add ability...". And please put the Change-Id as the last element behind "Releases...". Thx :) Thanks for the hint. I will heed this in the future. :) Should I add the "Depends" Information to the commit message as well? Because this features depends on the bugfix I63fb967c3d47286f24e4e469c4947a3c09047605 which I committed in 64109? I somehow overlooked this in the documentation so far. -
Björn Jacob commented on patch set 3 04/14/20, 09:38
> Patch Set 3: > > > Patch Set 2: > > > > Same here as in 64109 ;) > > > > > A nitpick. Regarding to the contribution guide please start with a capital letter "Add ability...". And please put the Change-Id as the last element behind "Releases...". Thx :) > > Thanks for the hint. I will heed this in the future. :) > Should I add the "Depends" Information to the commit message as well? Because this features depends on the bugfix I63fb967c3d47286f24e4e469c4947a3c09047605 which I committed in 64109? I somehow overlooked this in the documentation so far. IMHO the relation chain shows this already. I am not sure if you've talked to Benni & Co but right now the core is in stab phase. So no features are allowed at this point of time. -
Uwe Trotzek commented on patch set 3 04/14/20, 14:25
> Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 2: > > > > > > Same here as in 64109 ;) > > > > > > > A nitpick. Regarding to the contribution guide please start with a capital letter "Add ability...". And please put the Change-Id as the last element behind "Releases...". Thx :) > > > > Thanks for the hint. I will heed this in the future. :) > > Should I add the "Depends" Information to the commit message as well? Because this features depends on the bugfix I63fb967c3d47286f24e4e469c4947a3c09047605 which I committed in 64109? I somehow overlooked this in the documentation so far. > > IMHO the relation chain shows this already. I am not sure if you've talked to Benni & Co but right now the core is in stab phase. So no features are allowed at this point of time. Okay. No problem. It's not a problem for me if this wont make it in 10LTS ;) But it should be in sometime in the future. :) -
Daniel Goerz wrote 10/09/20, 15:53
Topic set to workspaces -
Benni Mack wrote 11/29/21, 10:04
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 13:23
-
Oliver Klee commented on patch set 4 07/14/23, 11:37
Uwe, would you be willing to rebase and update this change (and check if it's still relevant)? -
Andreas Nedbal uploaded patch set 5 11/24/23, 10:18
-
Andreas Nedbal uploaded patch set 6 11/24/23, 10:22
-
Andreas Nedbal uploaded patch set 7 11/24/23, 10:23
-
core-ci voted on patch set 5 V -1 11/24/23, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49866
-
Andreas Nedbal rebased onto patch set 8 11/24/23, 10:34
The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js -
core-ci voted on patch set 6 V -1 11/24/23, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49868
-
Andreas Nedbal uploaded patch set 9 11/24/23, 10:39
-
core-ci voted on patch set 7 V -1 11/24/23, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49869
-
Andreas Nedbal marked it ready for review 11/24/23, 10:41
-
core-ci voted on patch set 8 V -1 11/24/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49874
-
core-ci voted on patch set 9 V -1 11/24/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49876
-
Benni Mack updated the commit message in patch set 10
V -111/24/23, 23:51 -
core-ci voted on patch set 10 V -1 11/24/23, 23:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49912
-
Oliver Klee wrote 08/25/24, 10:12
Removed cc Oliver Klee. -
Benni Mack marked it work in progress 03/27/25, 08:40
-
Benni Mack abandoned the change 03/27/25, 12:02
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/88795