Review 9.5 Merged

64149[BUGFIX] Ignore includeNotInMenu for the section menu of the current page

Benni Mack CR +2 V +2 Easy +10 −0 updated 04/21/20, 12:43

Commit message

The option includeNotMenu is set to 1 if the CType menu_section is used
to render a section menu for the current page even if the page is hidden
in menus (pages.nav_hide).

This patch adds also the necessary stdWrap functionality to the abstract
class for hierarchical menus.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 911

  1. Benni Mack commented on patch set 1 04/20/20, 12:44

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php
  2. TYPO3com voted on patch set 1 V -1 04/20/20, 12:45 Completed build in 22s on Mon, 20 Apr, 12:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-494

  3. Josef Glatz commented on patch set 1 V -1 CR -1 04/20/20, 12:51

    on it
  4. Benni Mack commented on patch set 1 04/20/20, 14:02

    This change is ready for review.
  5. Benni Mack wrote 04/20/20, 14:02

    Assignee added: Josef Glatz <josefglatz@gmail.com>
  6. Josef Glatz uploaded patch set 2 04/20/20, 20:58

  7. TYPO3com voted on patch set 2 V +1 04/20/20, 21:10 Completed build in 11m 54s on Mon, 20 Apr, 09:10 PM Test Summary: 74789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-497

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/20/20, 21:14

  9. Josef Glatz wrote 04/21/20, 02:48

    Assignee deleted: Josef Glatz <josefglatz@gmail.com>
  10. Benni Mack voted on patch set 2 V +2 CR +2 04/21/20, 12:43

  11. Benni Mack merged patch set 3 04/21/20, 12:43