Review main Merged

64156[BUGFIX] Fix PackageManager event binding

Benjamin Franzke CR +2 V +2 Easy +13 −16 updated 04/17/20, 08:10

Commit message

PackageManager can not have DI tags assigned as it is a early container
instance (injected from core Bootstrap). That caused the
'packagesMayHaveChanged' event to never be executed.

We rather need to hookup the event listener using a service
provider that extends the ListenerProvider. (That's pretty much
the same, what the DI tags do in the background as well.)

Notes:
 1) To avoid similar future mistakes we also remove the unneeded
    `autoconfigure: false` from Configuration.yaml
 2) This restriction (no DI tag configuration) does only apply to early
    instance services, which is a static list of core TYPO3 services.
 3) We additionally drop the currently unused event callback
    PackageManager::beforeInstallationEventListener.
    It was not fully migrated to a PSR-14 event callback in #90249, which
    revealed that it is actually unneeded. The signal callback was
    introduced with #52766 in EXT:extensionmanager/ext_localconf.php,
    but became obsolete with later fixes: #71071 and #71455
    ExtensionManagementService now calls (through Install/ListUtility)
    directly into packageManager instead of (mis-)using a signal/event.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3