64162[TASK] Mark various code related to Backend user / DataHandler internal
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Utility/BackendUtility.php1+24 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+24 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+139 −1
- typo3/sysext/core/Documentation/Changelog/master/Important-91095-VariousMethodsAndPropertiesOfBackend-relatedCoreAPIsNowInternal.rstnew+234 −0
Review log 912
-
Benni Mack uploaded patch set 1 04/14/20, 11:59
-
TYPO3com voted on patch set 1 V +1 04/14/20, 12:14 Completed build in 14m 15s on Tue, 14 Apr, 12:14 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2492
-
Benni Mack uploaded patch set 2 04/15/20, 20:53
-
TYPO3com voted on patch set 2 V +1 04/15/20, 21:07 Completed build in 13m 55s on Wed, 15 Apr, 09:07 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2613
-
Benni Mack uploaded patch set 3 04/17/20, 15:53
-
TYPO3com voted on patch set 3 V +1 04/17/20, 16:06 Completed build in 12m 17s on Fri, 17 Apr, 04:06 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2745
-
Georg Ringer commented on patch set 3 V +1 CR +1 04/17/20, 18:58
-
Oliver Hader voted on patch set 3 V +2 CR +2 04/17/20, 21:09
-
Oliver Hader commented on patch set 3 04/17/20, 21:10
If PHP would have a read-only getter, it would be okay to consume those public properties... anyway, looks good to me in general -
Oliver Hader merged patch set 4 04/17/20, 21:10
-
Markus Klein commented on patch set 4 04/24/23, 11:44
DataHandler.php:119This is related to isImporting and actually public API when DataHandler is used for (recurring) imports. -
Benni Mack commented on patch set 4 04/24/23, 12:10
DataHandler.php:119Replyit's been 3 years, feel free to push a patch to re-introduce the option.
BackendUtility.php:887Unresolved