Review main Merged

64162[TASK] Mark various code related to Backend user / DataHandler internal

Benni Mack CR +2 V +2 Hard +421 −1 updated 04/24/23, 12:10

Commit message

In order to build a stronger Permission Handling system and
a stronger API for TCA resolving in TYPO3 v11, several methods and public
properties have been marked as "internal". These continue to be working
as is for TYPO3 v10 LTS, but are now marked as internal - most of the code
has been coming from PHP4 where no visibility restrictions have been available
back then.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 912

  1. Benni Mack uploaded patch set 1 04/14/20, 11:59

  2. TYPO3com voted on patch set 1 V +1 04/14/20, 12:14 Completed build in 14m 15s on Tue, 14 Apr, 12:14 PM Test Summary: 73472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2492

  3. Benni Mack uploaded patch set 2 04/15/20, 20:53

  4. TYPO3com voted on patch set 2 V +1 04/15/20, 21:07 Completed build in 13m 55s on Wed, 15 Apr, 09:07 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2613

  5. Benni Mack uploaded patch set 3 04/17/20, 15:53

  6. TYPO3com voted on patch set 3 V +1 04/17/20, 16:06 Completed build in 12m 17s on Fri, 17 Apr, 04:06 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2745

  7. Georg Ringer commented on patch set 3 V +1 CR +1 04/17/20, 18:58

    BackendUtility.php:887 Unresolved

    is there a reason why you skip a description?
  8. Oliver Hader voted on patch set 3 V +2 CR +2 04/17/20, 21:09

  9. Oliver Hader commented on patch set 3 04/17/20, 21:10

    If PHP would have a read-only getter, it would be okay to consume those public properties... anyway, looks good to me in general
  10. Oliver Hader merged patch set 4 04/17/20, 21:10

  11. Markus Klein commented on patch set 4 04/24/23, 11:44

    DataHandler.php:119

    This is related to isImporting and actually public API when DataHandler is used for (recurring) imports.
  12. Benni Mack commented on patch set 4 04/24/23, 12:10

    DataHandler.php:119 Reply

    it's been 3 years, feel free to push a patch to re-introduce the option.