Review main Merged

64181[TASK] Add final private constructor to GeneralUtility

Alexander Schnitzler CR +2 V +2 Easy +5 −2 updated 04/15/20, 16:01

Commit message

GeneralUtility is a class with only static methods and
a class comment stated for years not to instantiate it.

Since there is a possibility to prevent instantiations
of classes with private constructors, one has added to
this class and on top is has been marked final.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Alexander Schnitzler uploaded patch set 1 04/15/20, 11:30

  2. TYPO3com voted on patch set 1 V +1 04/15/20, 11:42 Completed build in 12m 04s on Wed, 15 Apr, 11:42 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2569

  3. Alexander Schnitzler updated the commit message in patch set 2 04/15/20, 11:56

  4. Oliver Klee voted on patch set 2 CR +1 04/15/20, 12:00

  5. TYPO3com voted on patch set 2 V +1 04/15/20, 12:08 Completed build in 12m 19s on Wed, 15 Apr, 12:08 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2573

  6. Andreas Kienast voted on patch set 2 CR +1 04/15/20, 12:23

  7. Benni Mack voted on patch set 2 V +1 CR +1 04/15/20, 13:21

  8. Oliver Hader commented on patch set 2 CR +1 04/15/20, 13:22

    Breaking, but documented & I like it...
  9. Benni Mack voted on patch set 2 V +2 CR +2 04/15/20, 16:01

  10. Benni Mack merged patch set 3 04/15/20, 16:01