64183[BUGFIX] Ignore includeNotInMenu for the section menu of the current page
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1419
-
Josef Glatz uploaded patch set 1 04/15/20, 11:59
-
Josef Glatz commented on patch set 1 04/15/20, 12:00
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 04/15/20, 12:39 Completed build in 36m 02s on Wed, 15 Apr, 12:39 PM Test Summary: 8 of 74007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2574
-
Josef Glatz commented on patch set 1 04/15/20, 13:47
MenuSection.typoscript:12UnresolvedJust for clarification: We can use the stdWrap function override without assigning a default, since the default is already 0 for includeNotInMenu. -
TYPO3com voted on patch set 1 V +1 04/15/20, 13:50 Completed build in 44m 50s on Wed, 15 Apr, 01:50 PM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2579
-
Oli Bartsch commented on patch set 1 04/15/20, 16:07
AbstractMenuContentObject.php:245This should be `$this->conf['includeNotInMenu.'] ?? null` -
Josef Glatz commented on patch set 2 04/15/20, 16:29
Published edit on patch set 1. -
Josef Glatz commented on patch set 2 04/15/20, 16:30
AbstractMenuContentObject.php:245ReplyDone -
TYPO3com voted on patch set 2 V +1 04/15/20, 16:42 Completed build in 12m 58s on Wed, 15 Apr, 04:42 PM Test Summary: 73571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2594
-
Oli Bartsch uploaded patch set 3 04/17/20, 05:56
-
Oli Bartsch voted on patch set 3 V +1 CR +1 04/17/20, 05:57
-
TYPO3com voted on patch set 3 V +1 04/17/20, 06:09 Completed build in 12m 07s on Fri, 17 Apr, 06:09 AM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2681
-
Benni Mack voted on patch set 3 CR +1 04/17/20, 07:56
-
Josef Glatz rebased onto patch set 4 04/20/20, 11:26
-
Oli Bartsch voted on patch set 4 V +1 CR +1 04/20/20, 11:30
-
TYPO3com voted on patch set 4 V +1 04/20/20, 11:43 Completed build in 14m 03s on Mon, 20 Apr, 11:43 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2892
-
Benni Mack voted on patch set 4 V +2 CR +2 04/20/20, 12:44
-
Benni Mack merged patch set 5 04/20/20, 12:44
-
Josef Glatz commented on patch set 5 04/21/20, 07:11
Documentation PR created: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-Typoscript/pull/301