Review main Merged

64198[TASK] Disable rector for ServiceProviders to avoid auto_import_names

Benjamin Franzke CR +2 V +2 Normal +30 −37 updated 04/16/20, 07:54

Commit message

rectors `auto_import_names` causes relative class names to
be transformed into `use` statements.
This reduces the readability of the grouped
getFactories array as used in ServiceProviders, we rather used
to define all external dependencies in use statements and
to include local dependencies using relative class names.

Also revert the change in TYPO3\CMS\Extbase\ServiceProvider
which has already been applied in #91047 using:
  git checkout 682873dd61ccd398bcf58b1e76133b638cf5ecf9^ -- \
    typo3/sysext/extbase/Classes/ServiceProvider.php

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2