Review main Merged

64211[BUGFIX] Catch UnableToLinkToPageException in view module

Christian Eßl CR +2 V +2 Normal +54 −31 updated 04/20/20, 08:43

Commit message

If a requested page in the view module is missing a site configuration,
catch the related exception and show a meaningful flash message instead.

Review

  • Code review CR +2 Done
    • Christian Eßl +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Jonas Eberle +1
  • Verified V +2 Done
    • Christian Eßl +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1315

  1. Christian Eßl uploaded patch set 1 04/17/20, 12:46

  2. TYPO3com voted on patch set 1 V +1 04/17/20, 13:00 Completed build in 14m 31s on Fri, 17 Apr, 01:00 PM Test Summary: 73561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2720

  3. Georg Ringer voted on patch set 1 V +1 CR +1 04/17/20, 19:00

  4. Josef Glatz voted on patch set 1 CR +1 04/17/20, 19:29

  5. Josef Glatz voted on patch set 1 V +1 04/17/20, 19:30

  6. Guido Schmechel voted on patch set 1 V +1 CR +1 04/18/20, 10:50

  7. Guido Schmechel commented on patch set 1 04/18/20, 10:51

    ViewModuleController.php:189

    Nitpick: Here we can still discuss if a warning is better ;-)
  8. Christian Eßl uploaded patch set 2 04/18/20, 16:14

  9. Christian Eßl commented on patch set 2 04/18/20, 16:15

    ViewModuleController.php:189 Reply

    Done
  10. TYPO3com voted on patch set 2 V +1 04/18/20, 16:31 Completed build in 16m 58s on Sat, 18 Apr, 04:31 PM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2815

  11. Jonas Eberle voted on patch set 2 V +1 CR +1 04/18/20, 21:36

  12. Guido Schmechel voted on patch set 2 V +1 CR +1 04/19/20, 11:02

  13. Oli Bartsch voted on patch set 2 V +1 CR +1 04/19/20, 11:21

  14. Christian Eßl voted on patch set 2 V +2 CR +2 04/20/20, 08:43

  15. Christian Eßl merged patch set 3 04/20/20, 08:43