Review main Merged

64225[TASK] Reduce inline JavaScript in ext:setup

Oliver Hader CR +2 V +2 Hard +414 −68 updated 05/31/20, 07:58

Commit message

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings.

* moves inline JavaScript for avatar handling to new SetupModule
* avoids using configuration options `onClick`, `onClickLabels`
  and `confirmData.jsCodeAfterOk` which contain inline JavaScript
* introduces configuration options `conformationData.eventName`
  and `clickData.eventName` to substitute mentioned deprecations
* adds PSR-14 `AddJavaScriptModulesEvent` which allows to apply
  custom RequireJS modules to handle mentioned new custom events

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9