Review main Merged

64234[BUGFIX] Avoid using the symfony container to clear its own caches

Benjamin Franzke CR +2 V +2 Easy +26 −7 updated 04/19/20, 13:12

Commit message

With the introduction of a custom DI cache in #90418, the container
was used to lookup its own cache and the cache identifier. This
results in bugs if the container cache is stale:
Loading from the cache and flushing the cache will work, but code that
runs after the cache has been flushed (ext_localconf loading) will still
use the a stale container (configuration), as the instance has been
created too early (to be able to clear itself).

Therefore we do now avoid instantiating the symfony container before the
container cache has been cleared.

A positive side effect of this change is that the container cache is
warmed up after the flush.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3