Review main Merged

64245[BUGFIX] Add missing parentheses in ViewModule doktype check

Oli Bartsch CR +2 V +2 Easy +7 −5 updated 04/19/20, 18:05

Commit message

Also simplify doktype check by using `in_array`
instead of comparing each doktype on its own.

Furthermore the check for the page row is superflous
because it is checked implicit by fetching the doktype.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Guido Schmechel +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 04/19/20, 11:39

  2. Wouter Wolters voted on patch set 1 CR +1 04/19/20, 11:48

  3. TYPO3com voted on patch set 1 V +1 04/19/20, 11:50 Completed build in 11m 21s on Sun, 19 Apr, 11:50 AM Test Summary: 73627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2840

  4. Christian Eßl voted on patch set 1 V +1 CR +1 04/19/20, 11:57

  5. Oliver Klee voted on patch set 1 CR +1 04/19/20, 12:06

  6. Guido Schmechel voted on patch set 1 CR +1 04/19/20, 12:55

  7. Georg Ringer voted on patch set 1 V +2 CR +2 04/19/20, 18:05

  8. Georg Ringer merged patch set 2 04/19/20, 18:05