Review main Merged

64246[BUGFIX] Migrate mail SMTP encrypt option for symfony/mailer compatibility

Benjamin Franzke CR +2 V +2 Normal +66 −2 updated 04/28/20, 06:07

Commit message

SMTP encrypt options were quite a hassle with swiftmailer:
'tls' was used as identifier to start a STARTTLS connection via SMTP
(instead of using SMTPS), while strings like ssl/tlsv1.0/tlsv1.1/tlsv1.2
instructed to use a SSL/TLS connection via SMTPS (without STARTTLS).

symfony/mailer does no longer allow to specify the STARTTLS usage,
as it will use it by default (if the server provides support for it).

Therefore, we now adapt the SMTP encryption configuration setting
via a silent configuration upgrade to avoid that the previous
STARTTLS 'tls' is casted to true while symfony/mailer expects false/null.

While at it, we also fix an incorrect migration for the transport type
'mail'. This wizard didn't work because of a wrong typecast (which has
probably been a copy & paste mistake).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3