Review main Merged

64251[BUGFIX] Skip dynamically assigned instance names in extension scanner

Oliver Hader CR +2 V +2 Easy +7 −3 updated 04/19/20, 19:59

Commit message

Dynamically created class instances using a variable name cannot be
resolved in extension scanner - given the fact that a class member
variable can change at any time and the scanner would have to keep
that state - which is too much for static code analysis.

Thus, the following source code is not analyzed.

$className = SomeClass::class;
$object = GeneralUtility($className);

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3