Review main Merged

64263[TASK] Allow DI based services in localconf during extension install

Benjamin Franzke CR +2 V +2 Normal +43 −8 updated 04/27/20, 19:13

Commit message

We fix PackageManager and ContainerBuilder to allow
multiple container instances (including multiple
cache identifiers) to be live.
ExtensionManager will now load a new symfony container
after installing a new extension, and before reloading
all ext_localconf files. We need to ensure that possible
services in ext_localconf can be loaded when they
depend on symfony DI.

Note: This is not a BUGFIX as this was never
supported for extensions. But it may lead to hard-to-debug
bugs when extension developers add a service to ext
localconf but do not test the re-installation procedure
before publishing the extension to TER.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4