Review 9.5 Merged

64280[BUGFIX] Remove $scheme from LegacyLinkNotationConverter::resolve()

Benni Mack CR +2 V +2 Easy +2 −8 updated 04/21/20, 13:10

Commit message

The code block using $scheme is never reached, because there is already
an elseif condition further above, that is true for all urls containing
":".

The last else block even states in the comment:
"special handling without a scheme"

Therefore the variable is removed to remove a bit of complexity from the
function.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1