64296[DOCS] Add dashboard widget registration example via Services.php
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Josef Glatz +1
- Oli Bartsch +1
- Björn Jacob +1
-
Verified V +2 Done
- Richard Haeser +2
- Josef Glatz +1
- Oli Bartsch +1
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1317
-
Daniel Siepmann uploaded patch set 1 04/21/20, 17:07
-
Daniel Siepmann uploaded patch set 2 04/21/20, 17:09
-
TYPO3com voted on patch set 1 V -1 04/21/20, 17:19 Completed build in 11m 46s on Tue, 21 Apr, 05:19 PM Test Summary: 1 of 74141 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2952
-
TYPO3com voted on patch set 2 V +1 04/21/20, 17:25 Completed build in 15m 07s on Tue, 21 Apr, 05:25 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2953
-
Björn Jacob commented on patch set 2 CR -1 04/21/20, 19:01
Some minor remarks."a"WidgetRegistration.rst:233Is it better to say "only executed during"? It took me some time to understand the sentence.WidgetRegistration.rst:234"Therefore, "WidgetRegistration.rst:236"Instead, "WidgetRegistration.rst:238"a"WidgetRegistration.rst:247Already new CGL. Sweet :)WidgetRegistration.rst:276Isn't it "exampleWidget"?WidgetRegistration.rst:279"a"WidgetRegistration.rst:280I thought we are going with uppercase in the docs. Not sure though.WidgetRegistration.rst:288"works"WidgetRegistration.rst:290"PHP"WidgetRegistration.rst:290"YAML"? -
Daniel Siepmann uploaded patch set 3 04/22/20, 05:26
-
Daniel Siepmann commented on patch set 3 04/22/20, 05:26
Reply
DoneWidgetRegistration.rst:233ReplyDoneWidgetRegistration.rst:234ReplyDoneWidgetRegistration.rst:236ReplyDoneWidgetRegistration.rst:238ReplyDoneWidgetRegistration.rst:247ReplyJust copied from Richards real world example :DWidgetRegistration.rst:276ReplyGood catch, found some more and replaced them with "example*"WidgetRegistration.rst:279ReplyDoneWidgetRegistration.rst:280ReplyAlso not sure, but switched to YAML, as that's how it is written on official website: https://yaml.org/WidgetRegistration.rst:288ReplyDoneWidgetRegistration.rst:290ReplyDoneWidgetRegistration.rst:290ReplyDone -
Björn Jacob commented on patch set 3 04/22/20, 05:32
Awesome. One final thing from my side.WidgetRegistration.rst:287IMHO "suggested" -
TYPO3com voted on patch set 3 V -1 04/22/20, 05:52 Completed build in 25m 53s on Wed, 22 Apr, 05:52 AM Test Summary: 23 of 71524 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2963
-
Daniel Siepmann uploaded patch set 4 04/22/20, 07:24
-
Daniel Siepmann commented on patch set 4 04/22/20, 07:25
WidgetRegistration.rst:287ReplyDone -
Björn Jacob voted on patch set 4 V +1 CR +1 04/22/20, 07:25
-
TYPO3com voted on patch set 4 V +1 04/22/20, 07:50 Completed build in 22m 54s on Wed, 22 Apr, 07:50 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2969
-
Oli Bartsch voted on patch set 4 V +1 CR +1 04/22/20, 08:37
-
Josef Glatz voted on patch set 4 V +1 CR +1 04/22/20, 10:00
-
Richard Haeser voted on patch set 4 V +2 CR +2 04/22/20, 10:09
-
Richard Haeser merged patch set 5 04/22/20, 10:09