Review main Merged

64325[BUGFIX] Fix inline icon rendering of bitmap icons

Benjamin Franzke CR +2 V +2 Easy +6 −7 updated 04/28/20, 07:27

Commit message

The existing "inline" rendering for icons causes bitmaps to be
rendered for SVG-inline usage using the <image> tag. This tag
can not be rendered in HTML context.

The backend module menu uses inlined SVGs. Rendering bitmap icons with
SVG-syntax, without an SVG root element, does not work in this context.
(Note: It works in SVG trees because the optional svg container is
removed by SvgTree.js and the image-tag is wrapped into a new <g> element)

We do now wrap "inline" bitmap icons into an svg tag, which will fix
the bitmap module case while the bitmap icons will still
be embeddable into svg groups (<g>) for svg trees.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2