Review main Merged

64328[BUGFIX] Allow deletion of records in tables without soft delete

Helmut Hummel CR +2 V +2 Normal +52 −29 updated 04/28/20, 07:37

Commit message

\TYPO3\CMS\Install\Updates\DatabaseRowsUpdateWizard currently can only
update rows.

\TYPO3\CMS\Install\Updates\RowUpdater\WorkspaceVersionRecordsMigration
however needs to delete rows and marks them as deleted.
We now check for this value for tables without soft delete
and delete the row straight away

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Helmut Hummel uploaded patch set 1 04/27/20, 21:30

  2. TYPO3com voted on patch set 1 V -1 04/27/20, 21:43 Completed build in 12m 52s on Mon, 27 Apr, 09:43 PM Test Summary: 1 of 74142 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3069

  3. TYPO3com voted on patch set 1 V +1 04/28/20, 05:23 Completed build in 8h 06m 30s on Tue, 28 Apr, 05:23 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3069

  4. Benni Mack voted on patch set 1 V +1 CR +1 04/28/20, 05:51

  5. Susi Moog voted on patch set 1 V +2 CR +2 04/28/20, 07:37

  6. Susi Moog merged patch set 2 04/28/20, 07:37