Review main Merged

64343[BUGFIX] Explicitly fetch element by ID instead of invoking querySelector

Andreas Kienast CR +2 V +2 Easy +17 −17 updated 05/01/20, 11:38

Commit message

The InlineControlContainer tried to fetch elements via `querySelector()`
previously. This fails once the selector contains a character that has a
specific meaning for the whole selector, e.g. a dot. Having a selector
`#foo-bar-settings.test` instructs the query selector to fetch an
element matching the ID `foo-bar-settings` and the class `test`.

As we handle IDs only, we can safely use `getElementById()` which
doesn't have the previously mentioned implications.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2