Review main Merged

64385[BUGFIX] Use class instead of HTML comment to determine loading state of IRRE element

Andreas Kienast CR +2 V +2 Easy +15 −10 updated 05/03/20, 13:51

Commit message

IRRE relied on the HTML comment `<!--notloaded-->` to detect whether a
record is already loaded or not. As this might collide with HTML
minification, the comment has been replaced with a class placed in the
panel.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Xavier Perseguers +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Xavier Perseguers +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Andreas Kienast uploaded patch set 1 05/01/20, 14:13

  2. TYPO3com voted on patch set 1 V -1 05/01/20, 14:13 Completed build in 19s on Fri, 1 May, 02:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3149

  3. Andreas Kienast uploaded patch set 2 05/01/20, 14:15

  4. TYPO3com voted on patch set 2 V +1 05/01/20, 14:27 Completed build in 11m 12s on Fri, 1 May, 02:27 PM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3150

  5. Xavier Perseguers commented on patch set 2 V +1 CR +1 05/02/20, 07:34

    That's really nice! Thanks.
  6. Susi Moog voted on patch set 2 CR +1 05/02/20, 12:00

  7. Susi Moog voted on patch set 2 V +1 05/02/20, 12:02

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 05/03/20, 13:51

  9. Andreas Kienast merged patch set 3 05/03/20, 13:51