Review main Merged

64399[BUGFIX] Strip tags from RSS items in Dashboard widget

Chris Müller CR +2 V +2 Easy +3 −3 updated 02/01/21, 21:24

Commit message

As the output of the widgets in the Dashboard is processed
by htmlspecialchars(), the tags need to be stripped before
to prevent showing the full tags as text.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Chris Müller +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Chris Müller +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1824

  1. Chris Müller uploaded patch set 1 05/04/20, 09:26

  2. TYPO3com voted on patch set 1 V +1 05/04/20, 09:42 Completed build in 15m 08s on Mon, 4 May, 09:42 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3184

  3. Josef Glatz commented on patch set 1 CR -1 05/05/20, 07:24

    Is this something

    RssWidget.php:115

    is this something we must do generally? What if someone has a specific rss feed for a TYPO3's project dashboard where such html tags are wanted?
  4. Chris Müller uploaded patch set 2 05/11/20, 07:55

  5. Chris Müller commented on patch set 2 05/11/20, 07:57

    RssWidget.php:115 Reply

    I added a new option for removing tags if desired.
  6. TYPO3com voted on patch set 2 V -1 05/11/20, 08:09 Completed build in 14m 09s on Mon, 11 May, 08:09 AM Test Summary: 3 of 74180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3300

  7. TYPO3com commented on patch set 2 05/11/20, 09:34 Completed build in 12m 09s on Mon, 11 May, 09:34 AM Test Summary: 73332 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3301

  8. TYPO3com voted on patch set 2 V +1 05/11/20, 09:49 Completed build in 11m 51s on Mon, 11 May, 09:49 AM Test Summary: 73696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3302

  9. Guido Schmechel commented on patch set 2 05/14/20, 09:54

    RssWidget.php:114

    IMO we should control also the option "allowable_tags". My thought: If someone removes tags already, then there are certainly people who want to keep certain tags.
  10. Josef Glatz commented on patch set 2 V -1 05/14/20, 14:34

    beside the allowed HTML tags idea: the documentation needs a proper adoption too

    RssWidget.php:114 Reply

    Nice idea! You're right. We definitely have to update the proper parts of the ext:dashboard manual with this patch too
  11. Benni Mack updated the commit message in patch set 3 05/25/20, 18:51

  12. Chris Müller commented on patch set 3 05/26/20, 15:18

    RssWidget.php:114 Reply

    Can you point me to a use case where it would be appropriate to show certain tags and some not? Also, which part of the manual was not updated? The RSS Widget reference is adjusted.
  13. Guido Schmechel commented on patch set 3 05/26/20, 15:41

    RssWidget.php:114 Reply

    All I have right now is a fictional case. Example: I would like to display images in the widget (img), but no other tags. Or I don't allow anything, but em, strong are allowed. (Highlighting of text) I just want to give people the opportunity, if we adjust that, to use other obvious options.
  14. Chris Müller commented on patch set 3 05/27/20, 15:17

    RssWidget.php:114 Reply

    Okay, but you know, that the tags are obviously htmlspecialchar'd? So you see something like in the issue: https://forge.typo3.org/issues/91289
  15. Richard Haeser commented on patch set 3 02/01/21, 08:59

    Personally, I don't see any reason to NOT strip the tags as they are "specialchard" anyway. So it should not even be an option but just fixing the bug and remove tags from the text. We might think about a new feature where we can have a "rich" feed option where you can have things like links / images etc. I will update the patch to be a bugfix for the current issue if you don't mind.
  16. Richard Haeser uploaded patch set 4 02/01/21, 09:15

  17. Richard Haeser updated the commit message in patch set 5 02/01/21, 09:15

  18. TYPO3com voted on patch set 4 V +1 02/01/21, 09:25 Completed build in 09m 27s on Mon, 1 Feb, 09:25 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9129

  19. TYPO3com voted on patch set 5 V +1 02/01/21, 09:29 Completed build in 12m 37s on Mon, 1 Feb, 09:29 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9130

  20. Richard Haeser voted on patch set 5 V +1 CR +1 02/01/21, 14:09

  21. Richard Haeser commented on patch set 5 02/01/21, 14:09

    RssWidget.php:114 Reply

    Done
  22. Chris Müller voted on patch set 5 V +1 CR +1 02/01/21, 15:55

  23. Richard Haeser voted on patch set 5 V +2 CR +2 02/01/21, 21:24

  24. Richard Haeser merged patch set 6 02/01/21, 21:24