Review 9.5 Merged

64465[SECURITY] Mitigate bypassing CSRF token via XSS

Oliver Hader CR +2 V +2 Hard +395 −6 updated 05/12/20, 09:43

Commit message

Cross-site scripting in same-site/same-origin context most probably
allows bypassing tokens that usually protects against cross-site
request forgery - basically that is obvious when focusing on
"cross-site" and "same-site" terminology.

To mitigate these scenarios, same-site requests from outside`/typo3/`
URI path - which is used to access the backend user interface - now
have to provide an HTTP `Referer` header which is enforced for global
routes potentially containing CSRF tokens.

In general all routes that switch their state internally from
`public` to `restricted` are relevant in this scenario. If really
necessary, the behavior can be disabled using corresponding feature
switch `security.backend.enforceReferrer` in TYPO3_CONF_VARS.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 22