Review main Merged

64476[BUGFIX] Make edit record bookmarks appear again

Helmut Hummel CR +2 V +2 Easy +2 −1 updated 08/22/20, 09:04

Commit message

The patch for issue #91210 introduced a side effect that bookmarks
to controllers which are not directly registered as backend modules
do not show up again because the ModuleLoader->checkMod() call does
not return an array anymore.
Bookmarks to records of FormEngine / EditDocumentController
are affected by this and are simply not rendered as bookmark
toolbar items.
The patch applies a hack to the ShortcutRepository to deal with
this. We need a better module / controller access API substituting
TBE_MODULES to deal with this properly. EditDocumentController
does it's own access checks for records, so the patch shouldn't
add security harm.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1