64487[BUGFIX] Check return value of hook before starting using it
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1011
-
Georg Ringer uploaded patch set 1 05/14/20, 07:37
-
Georg Ringer commented on patch set 1 05/14/20, 07:37
This change is ready for review. -
Oli Bartsch voted on patch set 1 CR +1 05/14/20, 07:45
-
TYPO3com voted on patch set 1 V +1 05/14/20, 07:48 Completed build in 11m 19s on Thu, 14 May, 07:48 AM Test Summary: 73708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3372
-
Josef Glatz voted on patch set 1 CR +1 05/14/20, 07:55
-
Andreas Kienast voted on patch set 1 CR +1 05/14/20, 08:39
-
Josef Glatz voted on patch set 1 V +1 05/14/20, 12:33
-
Susi Moog commented on patch set 1 05/15/20, 06:18
I would probably not do 9.5 here - problem is that you could have multiple hook implementations. If they are built using type hinting on array (which is currently safe to do) and you now add the possibility that $row is null, these implementations might now fail. -
Benjamin Franzke commented on patch set 1 CR -1 05/18/20, 13:13
I agree with Susi, that allowing `null` as new possible method parameter is a bit too breaking. It is essentially a new FEATURE, not a BUGFIX. I think we should rather add the functionality as PSR-14 event and leave the hook implementation as is. The PSR-14 event object could then be properly modeled to allow the row to be skipped ($skip = true) together with StoppableEventInterface to enforce that other events or the compat-hook will not do any other processing. The existing hook implementation can then stay as implemented currently. -
Benni Mack updated the commit message in patch set 2 05/25/20, 18:52
-
Georg Ringer abandoned the change 10/19/21, 19:02
abandoned, no interest